Hi!

On Thu, Sep 16, 2021 at 11:07:25AM +0200, Tobias Burnus wrote:
> As mentioned in https://gcc.gnu.org/PR102353 and in the patch,
> rs6000-gen-builtins was build to be run on "host" – and then linked and
> on on "build".
> 
> That caused bootstrap fails at link time.

> Tested with a x86_64-gnu-linux (build) → powerpc64le-linux-gnu (host,
> target) build.

Needs a native build, too, but Bill did that.  Okay.

> PowerPC: Fix rs6000-gen-builtins with build != host [PR102353]

> 
> This mimics what the main Makefile.in does: compile the generator
> files under build (with Makefile.in's 'build/%.o' rule for compilation).
> It also adds $(RUN_GEN) to optionally run it with valgrind and
> the $(build_exeext) suffix.
> 
> Before, the .o files were compiled with $(COMPILE), causing link
> error with $(LINKER_FOR_BUILD) for build != host.
> 
> gcc/
>       PR target/102353
>       * config/rs6000/t-rs6000 (build/rs6000-gen-builtins.o,
>       build/rbtree.o): Added 'build/' to target, use build/%.o rule.

You can break the line after the ":" fwiw.

>       (build/rs6000-gen-builtins$(build_exeext)): Add 'build/' and
>       '$(build_exeext)' to target and 'build/' for the *.o files.
>       (rs6000-builtins.c): Update for those changes; run
>       rs6000-gen-builtins with $(RUN_GEN).

The margin is at 80 chars for changelogs.

> -rs6000-gen-builtins: rs6000-gen-builtins.o rbtree.o
> +build/rs6000-gen-builtins$(build_exeext): build/rs6000-gen-builtins.o 
> build/rbtree.o $(BUILD_LIBDEPS)

Maybe break the prerequisites here (with "\"), the line is very long now?

Okay for trunk.  Thanks!


Segher

Reply via email to