On 02/21/2012 04:27 PM, Jakub Jelinek wrote: > On Tue, Feb 21, 2012 at 04:23:16PM +0100, Andreas Krebbel wrote: >> using the -fgnu-tm option fails for targets not supporting libitm with >> a *link* failure. So the compile test wasn't sufficient. >> >> With the attached patch the following failures disappear on s390 and >> s390x: >> >> FAIL: gcc.dg/lto/trans-mem-1 c_lto_trans-mem-1_0.o-c_lto_trans-mem-1_1.o >> link, -flto -fgnu-tm >> UNRESOLVED: gcc.dg/lto/trans-mem-1 >> c_lto_trans-mem-1_0.o-c_lto_trans-mem-1_1.o execute -flto -fgnu-tm >> FAIL: gcc.dg/lto/trans-mem-2 c_lto_trans-mem-2_0.o-c_lto_trans-mem-2_1.o >> link, -flto -fgnu-tm >> UNRESOLVED: gcc.dg/lto/trans-mem-2 >> c_lto_trans-mem-2_0.o-c_lto_trans-mem-2_1.o execute -flto -fgnu-tm >> FAIL: gcc.dg/lto/trans-mem-4 c_lto_trans-mem-4_0.o-c_lto_trans-mem-4_1.o >> link, -flto -fgnu-tm >> UNRESOLVED: gcc.dg/lto/trans-mem-4 >> c_lto_trans-mem-4_0.o-c_lto_trans-mem-4_1.o execute -flto -fgnu-tm >> XPASS: gcc.dg/tree-ssa/20040204-1.c scan-tree-dump-times optimized >> "link_error" 0 >> >> Ok for mainline? > > Won't that just disable tm testing on all targets? > As noted in bugzilla, libitm.spec is in the libitm tree, so runtime > tm testcases should probably be in libitm like e.g. libgomp has them.
Ok I see. I wasn't aware that the files would be missing even on targets supporting libtim. Thanks for the explanation. -Andreas-
