On Tue, Jul 20, 2021 at 09:48:26AM -0500, Segher Boessenkool wrote:
> > - if (mode == V4SFmode)
> > + switch (easy_altivec_constant (operands[1], <MODE>mode))
> > {
> > - mode = V4SImode;
> > - dest = gen_lowpart (V4SImode, dest);
> > + case 1: mode = V16QImode; break;
> > + case 2: mode = V8HImode; break;
> > + case 4: mode = V4SImode; break;
> > + default: gcc_unreachable ();
> > }
>
> case 1:
> mode = V16QImode;
> break;
> etc. (and/or make a convenience function for it).
Ok, will fix.
> > --- gcc/testsuite/gcc.dg/pr101384.c.jj 2021-07-13 13:45:42.971992584
> > +0200
> > +++ gcc/testsuite/gcc.dg/pr101384.c 2021-07-13 13:45:32.427135184 +0200
> > @@ -0,0 +1,39 @@
> > +/* PR target/101384 */
> > +/* { dg-do run } */
> > +/* { dg-options "-O2 -Wno-psabi -w" } */
>
> If you have -w anyway, do you / why do you still need -Wno-psabi?
I think not all of the -Wpsabi diagnostics is emitted with warning{,_at}
etc. that -w disables, others are emitted with inform. The -Wno-psabi
also makes it clear that it is the psabi stuff that is what the testcase
cares about. Whether -w is also needed or not is something I don't know,
in the past it certainly was needed on various architectures, but maybe it
got fixed and only -Wno-psabi would do the trick?
If so, perhaps we could replace all -Wno-psabi -w occurrences in testsuite
dg-options with just -Wno-psabi and see how far we get.
find testsuite/ -type f | xargs grep -- '-w -Wno-psabi' 2>/dev/null | grep -v
ChangeLog | wc -l
49
find testsuite/ -type f | xargs grep -- '-Wno-psabi -w' 2>/dev/null | grep -v
ChangeLog | wc -l
24
Jakub
