On 16 June 2021 05:09:17 CEST, Trevor Saunders <tbsau...@tbsaunde.org> wrote:
>> I'm curious why you keep the release() above and ... > >There was no particular reason, I just didn't make a very complete >search to remove them all, as they should be harmless. I'm certainly >happy to remove them, but wonder if it wouldn't make more sense to go >on >a broader search for uses of release and see why they are necessary or >remove them. Yes. One spot where you removed the early release() was in gimple_duplicate_sese_region and gimple_duplicate_sese_tail. I did wonder if there are adverse effects on memory usage for TUs with lots of basic blocks but you certainly thought about that when you removed the explicit doms.release(). thanks!