On 3/17/21 4:01 PM, Sandra Loosemore wrote:
I've checked in this patch, after having received a report a few days
ago that the nios2 back end was not building. Most of the changes here
are purely cosmetic.
Swapping out my nios2 maintainer hat for the documentation maintainer
one, though: the warning insisting that "floating point" should be
spelled "floating-point" is incorrect. "Floating point" is correct as a
noun and it's only appropriate to hyphenate the phrase when it's used as
an adjective immediately before some other noun or noun phrase, like
"floating-point processor". However, removing that warning and trying
to fix all the incorrect usages in the code seems like a can of worms,
since there are already released versions of GCC that will complain
about the correct spelling. Since this bogus diagnostic isn't a
regression and doesn't block builds, I'm not terribly enthusiastic about
trying to fix it this late in stage 4 even if it's technically
considered a documentation fix, so I've left that alone for now.
I probably missed the (adjective) part in the Spelling table in
the coding conventions. It should be easy to adjust the warning
to keep quiet when "floating point" is the end of a sentence.
That would suppress it in the five or so instances where it's wrong.
Alternatively, to avoid the warning with older GCC(*) we could change
these five messages and add some text after the "floating point" part
to make it an adjective.
That said, I count 52 instances in gcc.pot where it looks appropriate.
Martin
[*] Does -Wformat-diag really trigger when using older GCC to build?
I thought it only triggered in stage 2 and 3 when using the same GCC
to rebuild itself.
-Sandra
