On Montag, 1. Februar 2021 13:21:33 CET Rainer Orth wrote: > Two simd tests FAIL on Solaris, both SPARC and x86: > > FAIL: experimental/simd/standard_abi_usable.cc -msse2 -O2 -Wno-psabi (test > for excess errors) FAIL: experimental/simd/standard_abi_usable_2.cc -msse2 > -O2 -Wno-psabi (test for excess errors) > > This happens because the simd headers use identifiers documented in the > libstdc++ manual as reserved by system headers.
Sorry, this code was originally written as non-stdlib code, i.e. without any reserved identifiers. I had hoped I found all issues... > Fixed as follows, tested on i386-pc-solaris2.11, sparc-sun-solaris2.11, > and x86_64-pc-linux-gnu. > > Ok for master? Looks good to me. > As an aside, the use of vim: markers initially confused the hell out of > me. As an Emacs user, I rarely use vi for much more than a pager, but > when I wanted to check the lines mentioned in the g++ errors, I had no > idea what was going on or how to disable the folding enabled there: > > // vim: foldmethod=marker sw=2 noet ts=8 sts=2 tw=80 > > I can't help but feel that this is just a personal preference and > doesn't belong into the upstream code. Yes. I guess it's better to remove at least foldmethod. The rest isn't personal preference, but coding style requirements. However, I don't need any of it anymore: by now my vim config autodetects GCC / libstdc++ code. If the rest of libstdc++ doesn't have it, the simd headers probably shouldn't have it either. Best, Matthias -- ────────────────────────────────────────────────────────────────────────── Dr. Matthias Kretz https://mattkretz.github.io GSI Helmholtz Centre for Heavy Ion Research https://gsi.de std::experimental::simd https://github.com/VcDevel/std-simd ──────────────────────────────────────────────────────────────────────────
