Rainer Orth <r...@cebitec.uni-bielefeld.de> wrote:

maybe this is enough to cover all bases without having to do any version or
target checks. (untested)

objdump is not available on quite a few Darwin versions with perfectly
functional
uleb128 - so I don’t want to punt on those for absence of it.  We already
check for
otool elsewhere.

thoughts?

LGTM, with one nit:

[[
if test "x$gcc_cv_objdump" != x; then
if $gcc_cv_objdump --full-contents conftest.o 2>/dev/null \

I'd use $gcc_cv_objdump -s here (maybe adding -j .data), matching the
other equivalent objdump invocations in gcc/configure.

OK - I need to check on compatibility between GNU objdump and LLVM objdump.
(since newer Darwin and GCN will be using the latter).

-s might work OK since we only have one section, but -j is problematic wit
different section naming conventions.

corollary: one should not assume that other invocations of objdump in configure
are working as expected if the objdump is the LLVM one.

cheers
Iain

Reply via email to