On 11/5/20 4:32 PM, will schmidt wrote: > On Wed, 2020-11-04 at 14:42 -0600, Pat Haugen via Gcc-patches wrote: >> * config/rs6000/rs6000.c (rs6000_final_prescan_insn): Only add 'p' for >> PREFIXED_YES. > > The code change reads as roughly > - next_insn_prefixed_p != PREFIXED_NO > > + next_insn_prefixed_p == PREFIXED_YES" > > So just an inversion of the logic? I don't obviously see the 'p' impact > there. > It's no longer an inversion of the logic since I added a PREFIXED_ALWAYS value. 'next_insn_prefixed' is used by rs6000_final_prescan_insn() to determine whether an insn mnemonic needs a 'p' prefix. We want it set for PREFIXED_YES, but not for PREFIXED_NO or PREFIXED_ALWAYS.
> >> * config/rs6000/rs6000.md (define_attr "size"): Add 256. >> (define_attr "prefixed"): Add 'always'. >> (define_mode_attr bits): Add DD/TD modes. >> (cfuged, cntlzdm, cnttzdm, pdepd, pextd, bswaphi2_reg, bswapsi2_reg, >> bswapdi2_brd, setbc_<un>signed_<GPR:mode>, >> *setbcr_<un>signed_<GPR:mode>, *setnbc_<un>signed_<GPR:mode>, >> *setnbcr_<un>signed_<GPR:mode>): Update instruction attributes for >> Power10. > > ok. (assuming the assorted 'integer' -> 'crypto' changes are correct, > of course). > Yes, crypto represents the correct pipe the insns are executed on. Thanks for the review, Pat
