On Wed, Oct 28, 2020 at 6:26 AM Alan Modra <amo...@gmail.com> wrote:
>
> git commit badeac77f552 changed expected number of addi instructions,
> causing these fails on powerpc-linux.
>
> gcc.target/powerpc/fold-vec-insert-int-p9.c: \\maddi\\M found 12 times
> FAIL: gcc.target/powerpc/fold-vec-insert-int-p9.c scan-assembler-times 
> \\maddi\\M 8
> gcc.target/powerpc/fold-vec-extract-char.p9.c: addi found 6 times
> FAIL: gcc.target/powerpc/fold-vec-extract-char.p9.c scan-assembler-times addi 
> 3
> gcc.target/powerpc/fold-vec-extract-int.p9.c: \\maddi\\M found 6 times
> FAIL: gcc.target/powerpc/fold-vec-extract-int.p9.c scan-assembler-times 
> \\maddi\\M 3
> gcc.target/powerpc/fold-vec-extract-longlong.p7.c: \\maddi\\M found 6 times
> FAIL: gcc.target/powerpc/fold-vec-extract-longlong.p7.c scan-assembler-times 
> \\maddi\\M 4
> gcc.target/powerpc/fold-vec-extract-longlong.p8.c: \\maddi\\M found 6 times
> FAIL: gcc.target/powerpc/fold-vec-extract-longlong.p8.c scan-assembler-times 
> \\maddi\\M 4
> changed by badeac77f552
>
> I'm not at all sure why we are counting addi.  On linux I see
> eight in fold-vec-insert-int-p9.c tearing down the stack frame in
> function epilogues, and four in
>         addi 9,1,16
>         lvewx 0,0,9
> For aix you have the above four but with a -16 offset.  There are no
> stack frames, and you have four addressing stack red-zone as
>         addi 9,1,-64
>
> fold-vec-extract-char.p9.c on linux just has epilogue addi, aix has
> red-zone addressing.  The same for fold-vec-extract-int.p9.c,
> fold-vec-extract-longlong.p7.c and fold-vec-extract-longlong.p8.c.
>
> It seems silly to count addi in a function epilogue, and fragile to
> count them in code.  So remove the ilp32 addi checks.
>
> Regression tested powerpc64-linux and powerpc64le-linux.  OK?
>
>         * gcc.target/powerpc/fold-vec-extract-char.p9.c: Don't check addi
>         count for ilp32.
>         * gcc.target/powerpc/fold-vec-extract-int.p9.c: Likewise.
>         * gcc.target/powerpc/fold-vec-extract-longlong.p7.c: Likewise.
>         * gcc.target/powerpc/fold-vec-extract-longlong.p8.c: Likewise.
>         * gcc.target/powerpc/fold-vec-insert-int-p9.c: Likewise.

Okay.

Thanks, David

Reply via email to