Hi!
On Mon, Oct 12, 2020 at 01:15:32PM -0700, Carl Love wrote:
> Patch 1, adds the 128-bit sign extension instruction support and
> corresponding builtin support.
> * config/rs6000/altivec.h (vec_signextll, vec_signexti): Add define
> for new builtins.
> * config/rs6000/rs6000-builtin.def (VSIGNEXTI, VSIGNEXTLL): Add
> overloaded builtin definitions.
> (VSIGNEXTSB2W, VSIGNEXTSH2W, VSIGNEXTSB2D, VSIGNEXTSH2D,VSIGNEXTSW2D):
> Add builtin expansions.
> * config/rs6000-call.c (P9V_BUILTIN_VEC_VSIGNEXTI,
> P9V_BUILTIN_VEC_VSIGNEXTLL): Add overloaded argument definitions.
> * config/rs6000/vsx.md: Make define_insn vsx_sign_extend_si_v2di
> visible.
> * doc/extend.texi: Add documentation for the vec_signexti and
> vec_signextll builtins.
> +uThe following sign extension builtins are provided.
Typo ("uThe"). Probably should be a colon at the end, while you're at it.
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/powerpc/p9-sign_extend-runnable.c
> @@ -0,0 +1,128 @@
> +/* { dg-do run { target { powerpc*-*-linux* && { lp64 && p9vector_hw } } } }
> */
Why only on Linux? (And everything in gcc.target/powerpc/ is powerpc*
always, so could just be *-*-linux*).
Looks good otherwise.
Segher
