On Mon, 2020-10-05 at 11:52 -0700, Carl Love wrote: > Will, Segher: > > > > The following changes were made from the previous version: > > Per Will's comments, I split the bug fix from patch 2 into a separate > patch. This patch is the bug fix for the vec_rlnm builtin.
I recommend trying to keep a clean paragraph appropriate for the commit log, separate from the history of the patch. i.e. "This patch fixes an error in how the vec_rlnm() builtin parameters were handled." > > Regression tests reran on Power 9 LE with no regression errors. > > Please let me know if it looks OK to commit to mainline. > > Carl > > ---------------------------------------------------------- > > > gcc/ChangeLog > > 2020-10-05 Carl Love <c...@us.ibm.com> > > * config/rs6000/altivec.h (vec_rlnm): Fix bug in argument generation. Is there any testcase impact? (If this doesn't fix an existing test, may be worth adding one..) LGTM, Thanks -Will > --- > gcc/config/rs6000/altivec.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/rs6000/altivec.h b/gcc/config/rs6000/altivec.h > index 8a2dcda0144..f7720d136c9 100644 > --- a/gcc/config/rs6000/altivec.h > +++ b/gcc/config/rs6000/altivec.h > @@ -183,7 +183,7 @@ > #define vec_recipdiv __builtin_vec_recipdiv > #define vec_rlmi __builtin_vec_rlmi > #define vec_vrlnm __builtin_vec_rlnm > -#define vec_rlnm(a,b,c) (__builtin_vec_rlnm((a),((c)<<8)|(b))) > +#define vec_rlnm(a,b,c) (__builtin_vec_rlnm((a),((b)<<8)|(c))) > #define vec_rsqrt __builtin_vec_rsqrt > #define vec_rsqrte __builtin_vec_rsqrte > #define vec_signed __builtin_vec_vsigned
