Hi,

        Ok & Thanks, I will do my best for it :)

        It’s fixed in patch v7.

Jojo
在 2020年9月11日 +0800 PM11:29,Segher Boessenkool <seg...@kernel.crashing.org>,写道:
> Hi!
>
> On Fri, Sep 11, 2020 at 03:26:17PM +0800, Jojo R wrote:
> > +#define printf_include() do { \
>
> Don't use macros please, use a function?
>
> And maybe do this in a separate patch, for ease of review. That should
> be ack'ed pretty much immediately, after which it is out of the way, and
> we do not have to see it again.
>
> > while (read_md_rtx (&info))
> > - switch (GET_CODE (info.def))
>
> Factor this body to a separate function, too? Again, as earlier patch.
> As it is, it is impossible to see if you changed anything here.
>
> I suspect all this patch really does is pretty trivial, but it is hard
> to tell.
>
>
> Segher

Reply via email to