Hi! On Fri, Sep 11, 2020 at 03:26:17PM +0800, Jojo R wrote: > +#define printf_include() do { \
Don't use macros please, use a function? And maybe do this in a separate patch, for ease of review. That should be ack'ed pretty much immediately, after which it is out of the way, and we do not have to see it again. > while (read_md_rtx (&info)) > - switch (GET_CODE (info.def)) Factor this body to a separate function, too? Again, as earlier patch. As it is, it is impossible to see if you changed anything here. I suspect all this patch really does is pretty trivial, but it is hard to tell. Segher