Hello, On Fri, Jun 26, 2020 at 1:08 PM Jakub Jelinek <ja...@redhat.com> wrote:
> On Fri, Jun 26, 2020 at 12:57:59PM -0400, y2s1982 . wrote: > > > > * env.c(ompd_dll_locations_valid): Define with no compiler > > > optimization. > > > > > > Again, missing space. > > > > > > The contrib/mklog.py, which I use to generate these messages, seems to > > generate the statement without a space after the filename and before the > (. > > It seems like an easy fix of just adding a space like the following: > > diff --git a/contrib/mklog.py b/contrib/mklog.py > > index 243edbb15c5..0b01cde6fca 100755 > > --- a/contrib/mklog.py > > +++ b/contrib/mklog.py > > @@ -215,7 +215,7 @@ def generate_changelog(data, no_functions=False, > > fill_pr_titles=False): > > if functions: > > out += '\t* %s (%s):\n' % (relative_path, > > functions[0]) > > for fn in functions[1:]: > > - out += '\t(%s):\n' % fn > > + out += '\t (%s):\n' % fn > > else: > > out += '\t* %s:\n' % relative_path > > out += '\n' > > That is strange. The missing space I'm complaining about, e.g. between > env.c and (, is there in the above snippet, that is > '\t* %s (%s):\n' > ^--------- this one > and the space you are adding to mklog.py is undesirable, when one modifies > multiple functions, it should look like: > * env.c (foo): Something. > (bar): Something else. > rather than > * env.c (foo): Something. > (bar): Something else. > I see. I was thinking that doesn't make much sense, too, but when tested, it placed a space between the filename and the (. I wasn't sure what to make of it. Maybe my editor is somehow manipulating spaces and tabs when loading the patch for final editing or maybe the script I made is doing something more than just pasting the output of the contrib/mklog.py to the patch. Thanks for pointing it out. I will investigate further. Cheers, Tony Sim > > Jakub > >
