Thanks, just nits, no need to repost, just commit it after you make those
changes.
On Thu, Jun 25, 2020 at 05:58:23PM -0400, y2s1982 via Gcc-patches wrote:
> * Makefile.am(toolexeclib_LTLIBRARIES): Add libgompd.la.
Missing space between am and (.
> (libgompd_la_LDFLAGS, libgompd_la_DEPENDENCIES, libgompd_la_LINK,
> libgompd_la_SOURCES, libgompd_version_dep, libgompd_version_script,
> libgompd.ver-sun, libgompd.ver, libgompd_version_info): Set.
These lines are wrongly indented, should use tab instead of 8 spaces.
> * env.c(ompd_dll_locations_valid): Define with no compiler optimization.
Again, missing space.
> --- /dev/null
> +++ b/libgomp/libgompd.map
> @@ -0,0 +1,49 @@
> +OMPD_5.0 {
> + global:
> + ompd_dll_locations_valid;
ompd_dll_locations_valid is exported from libgomp.so.1, not libgompd.so.1,
so doesn't belong here.
> +ompd_rc_t
> +ompd_get_version_string (const char **string)
> +{
*string = "GNU OpenMP Runtime implementing OpenMP 5.0 "
ompd_stringify (OMPD_VERSION);
Please align ompd_stringify below "GNU.
Jakub
