Hi!
On Thu, Jun 18, 2020 at 03:20:14PM -0700, Carl Love wrote:
> +;; Map UNSPEC_SLDB to "l" and UNSPEC_SRDB to "r".
> +(define_int_attr SLDB_LR [(UNSPEC_SLDB "l")
> + (UNSPEC_SRDB "r")])
Most (all?) other attributes that always result in lower case strings
are written in lower case themselves; at least the part that just is the
possible expansions. So, "sldb_lr" or "SLDB_lr" please.
> + else if (icode == CODE_FOR_vsldb_v16qi
> + || icode == CODE_FOR_vsldb_v8hi
> + || icode == CODE_FOR_vsldb_v4si
> + || icode == CODE_FOR_vsldb_v2di
> + || icode == CODE_FOR_vsrdb_v16qi
> + || icode == CODE_FOR_vsrdb_v8hi
> + || icode == CODE_FOR_vsrdb_v4si
> + || icode == CODE_FOR_vsrdb_v2di)
> + {
> + /* Check whether the 3rd argument is an integer constant in the range
> + 0 to 7 inclusive. */
> + STRIP_NOPS (arg2);
> + if (TREE_CODE (arg2) != INTEGER_CST
> + || !IN_RANGE (TREE_INT_CST_LOW (arg2), 0, 7))
> + {
> + error ("argument 3 must be in the range 0 to 7");
> + return CONST0_RTX (tmode);
> + }
> + }
"must be a constant in the range"... maybe?
Okay for trunk with that considered (and the obvious testsuite changes
from the future->power10 changes). Thanks!
Segher
