On Wed, Apr 01, 2020 at 04:36:05PM -0500, Segher Boessenkool wrote: > On Wed, Apr 01, 2020 at 03:16:52PM -0400, Michael Meissner wrote: > > > > > -/* Support for a future processor's features. Do not enable -mpcrel > > > > > until it > > > > > - is fully functional. */ > > > > > +/* Support for a future processor's features. We do not set -mpcrel > > > > > or > > > > > + -mprefixed here. These bits are set in rs6000_option_override if > > > > > the system > > > > > + supports those options. */ > > > > > > > > I'm still not sure the comment here is actually necessary, there are > > > > many other places where we also do not set -mpcrel or -mprefixed. If > > > > history of the code here requires a hint to point at those options > > > > being set in rs6000_option_override, then it's fine. > > > > > > If you really need to say you do *not* do something, you should say why > > > not. Without that it only leaves more questions to the reader :-) > > > > > > Hopefully that then also explains why the reader should care about this. > > > > Given this comment is against Will's comment, and not the original code, is > > there anything I need to do to the code (other than the ChangeLog and > > adjusting > > object file format to ABI? > > I am agreeing with Will's comment here, just expanding on it. This > comment isn't helpful (maybe it would be with more provided context, > but as it is, it is not).
Ok, I will revist the comment. -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meiss...@linux.ibm.com, phone: +1 (978) 899-4797
