On Thu, 2020-03-26 at 14:23 -0500, Segher Boessenkool wrote:
> Hi!
>
> On Mon, Mar 23, 2020 at 03:18:25PM -0500, will schmidt wrote:
> > Disable the code that limits initialization of builtins based
> > on the rs6000_builtin_mask. This allows all built-ins to be
> > properly referenced when building code using #pragma for cpu
> > targets newer than what was specified by the -mcpu default.
> > The use of built-ins is still properly limited by logic within
> > altivec_resolve_overloaded_builtin().
> >
> > I'm still reviewing test results for any regressions.
> >
> > OK for master?
>
> Okay (if those tests pass ;-) ), thanks! Just a few nits:
They did. :-) I committed this on Monday.
Is this one also OK for backports? (after a week or so to let it bake
a bit more).
Thanks
-Will
>
>
> > * config/rs6000/rs6000-call.c
> > altivec_init_builtins(): Remove code
> > to skip defining builtins based on builtin_mask.
>
> * config/rs6000/rs6000-call.c (altivec_init_builtins): Remove
> code
> to skip defining builtins based on builtin_mask.
>
>
> > testsuite/
>
> gcc/testsuite/
>
>
> > --- /dev/null
> > +++ b/gcc/testsuite/gcc.target/powerpc/pragma_misc9.c
> > @@ -0,0 +1,47 @@
> > +/* { dg-do compile { target { powerpc*-*-* } } } */
>
> This is the default for anything in gcc.target/powerpc? { dg-do
> compile }
> can be useful (for a reader; for the test itself it is default as
> well),
> but drop the target selector please?
>
>
> Segher
