On 2/4/20 2:59 PM, Jakub Jelinek wrote:
On Tue, Feb 04, 2020 at 02:55:31PM +0100, Richard Biener wrote:
On Tue, Feb 4, 2020 at 2:45 PM Martin Liška <mli...@suse.cz> wrote:
Hi.
The patch is about enhancement of the documentation, where
we do not support ASLR for Precompiled Headers.
Ready for trunk?
I think we support ASLR just fine?
We do support ASLR just fine, just the PCH from it will not be bitwise
reproduceable. So the doc patch is misplaced (putting it between sentence
talking about options and the list of those options is weird) and should make
it clear that ASLR may result in non-reproduceable PCH files.
You are right. I fixed the placing of the hunk and relaxed the wording.
Martin
gcc/ChangeLog:
2020-02-04 Martin Liska <mli...@suse.cz>
PR c++/92717
* doc/invoke.texi: Document that one should
not combine ASLR and -fpch.
---
gcc/doc/invoke.texi | 2 ++
1 file changed, 2 insertions(+)
Jakub
>From f0b049bb709f3f7a1755abff0193dc40159c1d95 Mon Sep 17 00:00:00 2001
From: Martin Liska <mli...@suse.cz>
Date: Tue, 4 Feb 2020 14:43:35 +0100
Subject: [PATCH] Document ASLR for Precompiled Headers.
gcc/ChangeLog:
2020-02-04 Martin Liska <mli...@suse.cz>
PR c++/92717
* doc/invoke.texi: Document that one should
not combine ASLR and -fpch.
---
gcc/doc/invoke.texi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 4dec0c8326b..350d193ad22 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -31106,6 +31106,9 @@ precompiled header. The following are known to be safe:
-fsched-verbose=@var{number} -fschedule-insns -fvisibility= @gol
-pedantic-errors}
+@item Address space layout randomization (ASLR) can lead
+to non-reproducible results. We recommend to disable it.
+
@end itemize
For all of these except the last, the compiler automatically
--
2.25.0
