On 29/01/2020 15:40, Tobias Burnus wrote:
Hi Andrew,
On 1/29/20 2:01 PM, Andrew Stubbs wrote:
On 29/01/2020 12:53, Tobias Burnus wrote:
With LLVM 9, the old variant is only accepted when also passing
"-mattr=-code-object-v3" to the compiler; that's a"-" after the "="
to disable V3. […]
it turned out that at last the assembler of LLVM version 7.0.1
already supports this flag. Hence, we can go for the simpler solution
and use the assembler flag unconditionally.
OK for the trunk?
What testing have you done?
I tested building GCC both as amdgcn target compiler and as
x86-64-gnu-linux compiler with GCN offloading using LLVM 7.0.1. And I
tested building GCC for GCN as target compiler using LLVM 9.0.1 – I
also did (start) run the test suite for GCN as target compiler, only
(both LLVM 7 + 9) and got many PASS.
OK, in that case let's go ahead.
Any problems that do show in a full test run are unlikely to negate this
patch, given it's not exploded instantly.
Andrew
