On Wed, Jan 22, 2020 at 4:34 PM Jakub Jelinek <ja...@redhat.com> wrote:
>
> On Wed, Jan 22, 2020 at 04:22:54PM -0800, Andrew Pinski wrote:
> > > I see
> > > pr88497-1.c:/* { dg-require-effective-target vect_double } */
> > > pr88497-2.c:/* { dg-require-effective-target vect_float } */
> > > pr88497-3.c:/* { dg-require-effective-target vect_int } */
> > > pr88497-4.c:/* { dg-require-effective-target vect_int } */
> > > pr88497-5.c:/* { dg-require-effective-target vect_int } */
> > > is that just those?
> > Yes it is just those.
> > check_effective_target_vect_double calls into et-is-effective-target
> > for mips*-*-* target.
> > et-is-effective-target is only ever used by the MIPS targets.
> > It was introduced by g:9b7937cf8a06.
> >
> > So I did originally test it and it was working beforehand but I just
> > to retest it and I got the failures you listed below.
> > I also notice the setting of dg-do-what-default in
> > check_vect_support_and_set_flags now too :(.
>
> My preference would be to revert your patch and move those 5
> tests where they belong (i.e. gcc.dg/vect/) instead.I agree. Let me do that. I looked to see if "dg-require-effective-target vect_*" is used in any other testcase outside of gomp/graphite/vect/target testsuite and there is none other. Thanks, Andrew > > Jakub >
