On Wed, Jan 22, 2020 at 3:39 PM Jakub Jelinek <ja...@redhat.com> wrote:
>
> On Tue, Jan 21, 2020 at 05:56:38PM -0800, apin...@marvell.com wrote:
> > From: Andrew Pinski <apin...@marvell.com>
> >
> > tree-ssa testcases sometimes check autovect effective target
> > but does not set it up. On MIPS, those testcases fail with
> > some TCL error messages. This fixes the issue by calling
> > check_vect_support_and_set_flags inside tree-ssa.exp.
> > There might be other .exp files which need to be done this
> > way too but I have not checked all of them.
> >
> > OK? Tested on x86_64-linux-gnu and a cross to mips64-octeon-linux-gnu.
> > Both full run of the testsuite and running tree-ssa.exp by itself.
>
> I don't see how this could have been tested on x86_64-linux, it breaks there
> a lot of tests (ditto i686-linux). My wild guess is that it changes the
> default dg-do action for tests that don't have any, which in tree-ssa.exp
> used to be dg-do compile but now it tries to link them or run them.
> But it seems like it even affects the dg-do default for tests later in other
> *.exp files, e.g. various i386.exp tests, some ubsan.exp etc.
> What tree-ssa tests were the reason for this change?
> I see
> pr88497-1.c:/* { dg-require-effective-target vect_double } */
> pr88497-2.c:/* { dg-require-effective-target vect_float } */
> pr88497-3.c:/* { dg-require-effective-target vect_int } */
> pr88497-4.c:/* { dg-require-effective-target vect_int } */
> pr88497-5.c:/* { dg-require-effective-target vect_int } */
> is that just those?
Yes it is just those.
check_effective_target_vect_double calls into et-is-effective-target
for mips*-*-* target.
et-is-effective-target is only ever used by the MIPS targets.
It was introduced by g:9b7937cf8a06.
So I did originally test it and it was working beforehand but I just
to retest it and I got the failures you listed below.
I also notice the setting of dg-do-what-default in
check_vect_support_and_set_flags now too :(.
Thanks,
Andrew
> Or the tests that use vect_cmdline_needed effective target?
>
> +FAIL: gcc.dg/tree-ssa/20030920-1.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/20030920-1.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/builtin-snprintf-3.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/builtin-snprintf-3.c compilation failed to
> produce executable
> +FAIL: gcc.dg/tree-ssa/builtin-sprintf-7.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/builtin-sprintf-7.c compilation failed to
> produce executable
> +FAIL: gcc.dg/tree-ssa/builtin-sprintf-8.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/builtin-sprintf-8.c compilation failed to
> produce executable
> +UNRESOLVED: gcc.dg/tree-ssa/forwprop-29.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/ipa-split-3.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/ipa-split-3.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/ivopt_5.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/ivopt_5.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/loop-14.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/loop-14.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/loop-15.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/loop-15.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/loop-22.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/loop-22.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/pr20739.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/pr20739.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/pr25485.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/pr25485.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/pr25501.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/pr25501.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/pr26899.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/pr26899.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/pr77808.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/pr77808.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/pr84436-2.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/pr84436-2.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/pr84436-3.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/pr84436-3.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/pr86061.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/pr86061.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/pr87205-2.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/pr87205-2.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/pr87205.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/pr87205.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/pr87287.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/pr87287.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/ssa-dse-36.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/ssa-dse-36.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/ssa-dse-37.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/ssa-dse-37.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/ssa-dse-38.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/ssa-dse-38.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/switch-3.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/switch-3.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/upcast-1.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/upcast-1.c compilation failed to produce
> executable
> +FAIL: gcc.dg/tree-ssa/vrp103.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/vrp103.c compilation failed to produce executable
> +FAIL: gcc.dg/tree-ssa/vrp104.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/vrp104.c compilation failed to produce executable
> +FAIL: gcc.dg/tree-ssa/vrp106.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/vrp106.c compilation failed to produce executable
> +FAIL: gcc.dg/tree-ssa/vrp107.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/vrp107.c compilation failed to produce executable
> +FAIL: gcc.dg/tree-ssa/vrp108.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/vrp108.c compilation failed to produce executable
> +FAIL: gcc.dg/tree-ssa/vrp109.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/vrp109.c compilation failed to produce executable
> +FAIL: gcc.dg/tree-ssa/vrp110.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/vrp110.c compilation failed to produce executable
> +FAIL: gcc.dg/tree-ssa/vrp72.c execution test
> +FAIL: gcc.dg/tree-ssa/vrp73.c execution test
> +FAIL: gcc.dg/tree-ssa/vrp75.c execution test
> +FAIL: gcc.dg/tree-ssa/vrp97.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/vrp97.c compilation failed to produce executable
> +FAIL: gcc.dg/tree-ssa/wholeprogram-2.c (test for excess errors)
> +UNRESOLVED: gcc.dg/tree-ssa/wholeprogram-2.c compilation failed to produce
> executable
>
> Jakub
>
