> On Thu, 2020-01-16 at 20:43 +0100, Martin Liška wrote: > > Hi. > > > > The patch is fixes a regression in libgcrypt package where > > we incorrectly forget to stream out a definition of a no-reorder symbol. > > It's caused by LTO balanced map reversion, where we do not revert > > also best_noreorder_pos. > > > > It's pre-approved patch by Honza and I'm going to install it. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > > > Thanks, > > Martin > > > > > > gcc/lto/ChangeLog: > > > > 2020-01-16 Martin Liska <mli...@suse.cz> > > > > * lto-partition.c (lto_balanced_map): Remember > > best_noreorder_pos and then restore to it > > when we revert. > Thank you! That addressed several niggling failures.
Yep, it is quite intereesting the bug survived multiple releases since the initial Andi's kernel work. On the other hand it reproduces only if you mix in -O0 modules or use explicit -fno-toplevel-reorder. So if you see it in packages it is worth to investigate if build flags are not broken. -O0 -flto is not the most powerful optimization to do. Honza > > jeff > > >
