Hi!

On Tue, Nov 12, 2019 at 02:47:33PM +0300, Konstantin Kharlamov wrote:
> Last time a command that calls a function of debuggee with "set" was
> added is 2013 year. Apparently something has changed since then, since
> doing "set foo()" in gdb to call a "foo()" results in error.
> Disregarding, it looks wrong to call a function with "set". Let's use
> "call" instead.

I got a warning, not an error?  Your modified code works fine btw, also
with (at least some) older versions of GDB.

> * (debug_rtx,debug_rtx_list,debug_tree,debug_c_tree,debug_gimple_stmt,
> debug_gimple_seq,mpz_out_str,debug_dwarf_die,print_binding_stack,
> bitmap_print): Replace "set" with "call"

That changelog has multiple problems.  Please use something like this:

2019-11-13  Konstantin Kharlamov  <y...@email.here>

        * gdbinit.in (pr, prl, pt, pct, pgg, pgq, pgs, pge, pmz, pdd, pbs, pbm):
        Use "call" instead of "set".

Looks good to me otherwise, thanks!  (This is not an approval, I am not
maintainer of this part of GCC).


Segher

Reply via email to