On Oct 28, 2019, Joseph Myers <[email protected]> wrote:
> We have a test in the testsuite that all option help text consistently
> ends with '.' (see gcc.misc-tests/help.exp). I'd have expected these
> options, lacking that '.', to cause that test to fail.
Here's the patch. Tested on x86_64-linux-gnu. Ok to install?
Test --help=common for full sentences
The portion of help.exp that checks that help output contains full
sentences failed to cover common options.
for gcc/testsuite/ChangeLog
* gcc.misc-tests/help.exp: Test --help=common for full sentences.
---
gcc/testsuite/gcc.misc-tests/help.exp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gcc/testsuite/gcc.misc-tests/help.exp
b/gcc/testsuite/gcc.misc-tests/help.exp
index b8a09fc..4bb359f 100644
--- a/gcc/testsuite/gcc.misc-tests/help.exp
+++ b/gcc/testsuite/gcc.misc-tests/help.exp
@@ -146,8 +146,7 @@ check_for_options c "--help=joined,undocumented" "" "" ""
# find the source a failure.
foreach cls { "ada" "c" "c++" "d" "fortran" "go" \
- "optimizers" "param" "target" "warnings" } {
-
+ "common" "optimizers" "param" "target" "warnings" } {
check_for_options c "--help=$cls" "" "^ +-.*\[^:.\]$" ""
}
--
Alexandre Oliva, freedom fighter he/him https://FSFLA.org/blogs/lxo
Be the change, be Free! FSF VP & FSF Latin America board member
GNU Toolchain Engineer Free Software Evangelist
Hay que enGNUrecerse, pero sin perder la terGNUra jamás - Che GNUevara
