On Thu, Dec 1, 2011 at 5:19 PM, Uros Bizjak <ubiz...@gmail.com> wrote:
> 2011/12/1 Jan Hubicka <hubi...@ucw.cz>:
>
>>> >> Attached patch handles "*tm regparm" attribute, to avoid "*tm regparm"
>>> >> attribute ignored warnings in lto compile on non-x86 targets.
>>> >>
>>> >> 2011-11-30 Uros Bizjak <ubiz...@gmail.com>
>>> >>
>>> >> * lto-lang.c (lto_attribute_table): Handle *tm regparm.
>>> >> (ignore_attribute): New.
>>> >>
>>> >> Tested on alphaev68-pc-linux-gnu and x86_64-pc-linux-gnu {,-m32}.
>>> >>
>>> >> OK for mainline?
>>> >
>>> > Won't similar change be needed for other tm attributes? Perhaps we could
>>> > just
>>> > silence the warning with in_lto_p predicate.
>>>
>>> Doesn't it need to be handled as well, not just ignored?
>> I would expect stuff to be handled at parsing time and thus streamed into IL.
>
> Please see the comment. This attribute is intended to be redefined by
> the target-dependant handling, so my patch just prevents the warning
> (the code is copied from c-family/c-common.c). x86 targets that
> redefine the attribute handling work OK even without the patch,
> hinting at the fact that redefinition works OK. We just need to
> prevent warning for non-x86 targets.
The patch is ok.
Thanks,
Richard.
> Uros.
