ok for google branches. David
On Wed, Nov 30, 2011 at 6:09 AM, <dvyu...@google.com> wrote: > On 2011/11/30 13:17:04, Diego Novillo wrote: >> >> On 11-11-30 03:53 , mailto:dvyu...@google.com wrote: >> > On 2011/11/14 16:48:45, davidxl wrote: >> >> Ok for google/main after compiler bootstrap and regression test >> >> (without ftsan), and some large tests with tsan turned on (as many > > as >> >> >> you can but at your discretion). >> > >> > Hi David, >> > >> > Perhaps a bit late question... but better late than never. >> > I've added some unit tests, and I only tested them on Linux/x86 (and > > it >> >> > is the only platform that we currently care about). AFAIR I've seen > > some >> >> > sort of annotations to restrict tests to particular platforms. Does > > it >> >> > make sense to add them to the tests? > >> Yes, please. See http://gcc.gnu.org/onlinedocs/gccint/Directives.html > >> for documentation on the directives you can use. The testsuite/ >> directory is also full of examples you can cut-n-paste from. > > Here it is > http://codereview.appspot.com/5437087/ > > > http://codereview.appspot.com/5303083/ >
