On Thu, Aug 29, 2019 at 1:50 PM Andreas Schwab <sch...@linux-m68k.org> wrote: > > On Aug 28 2019, Ian Lance Taylor <i...@golang.org> wrote: > > > This patch to the Go frontend and libgo changes the panic message > > reported for an out of bounds index or slice operation to include the > > invalid values. > > This breaks aarch64/-mabi=ilp32. > > aarch64-suse-linux/ilp32/libgo/archive/tar/check-testlog: > > /usr/aarch64-suse-linux/bin/ld: _gotest_.o: in function > `archive..z2ftar.Reader.next': > /opt/gcc/gcc-20190829/Build/aarch64-suse-linux/ilp32/libgo/gotest1086/test/reader.go:72: > undefined reference to `runtime.goPanicExtendSliceAlen'
We should probably use a different GOARCH value for that build, such as arm64p32. But for now I'm committing this patch which will fix both problems by just always building panic32.go. Bootstrapped and tested on x86_64-pc-linux-gnu. Ian
Index: gcc/go/gofrontend/MERGE =================================================================== --- gcc/go/gofrontend/MERGE (revision 275227) +++ gcc/go/gofrontend/MERGE (working copy) @@ -1,4 +1,4 @@ -11fd9208f8545e882f945d3ed86fcc33abf1a61b +2444eb1e8c697531f8beb403679e4ab00b16dbf5 The first line of this file holds the git revision number of the last merge done from the gofrontend repository. Index: libgo/go/runtime/panic32.go =================================================================== --- libgo/go/runtime/panic32.go (revision 274998) +++ libgo/go/runtime/panic32.go (working copy) @@ -2,8 +2,6 @@ // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. -// +build 386 amd64p32 arm mips mipsle m68k nios2 sh shbe - package runtime import _ "unsafe" // for go:linkname
