Hi Ian,
> This patch to the Go frontend and libgo changes the panic message
> reported for an out of bounds index or slice operation to include the
> invalid values. This makes it easier for the user to see what the
> problem is. This implements https://golang.org/cl/161477 in the
> gofrontend, for https://golang.org/issue/30116. Bootstrapped and ran
> Go testsuite on x86_64-pc-linux-gnu. Committed to mainline.
>
> Unfortunately, GMail has once again blocked the patch attachment. So
> if you want to see the patch, see
> https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=274998 .
this patch broke sparc-sun-solaris2.11 bootstrap: in gotools I get
several link failures like this:
Undefined first referenced
symbol in file
runtime.goPanicExtendSliceAcap
../sparc-sun-solaris2.11/libgo/.libs/libgo.so
runtime.goPanicExtendSliceAlen
../sparc-sun-solaris2.11/libgo/.libs/libgo.so
runtime.goPanicExtendIndex
../sparc-sun-solaris2.11/libgo/.libs/libgo.so
runtime.goPanicExtendIndexU
../sparc-sun-solaris2.11/libgo/.libs/libgo.so
runtime.goPanicExtendSliceB
../sparc-sun-solaris2.11/libgo/.libs/libgo.so
runtime.goPanicExtendSliceAcapU
../sparc-sun-solaris2.11/libgo/.libs/libgo.so
runtime.goPanicExtendSliceBU
../sparc-sun-solaris2.11/libgo/libgotool.a(buildid.o)
ld: fatal: symbol referencing errors
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:829: buildid] Error 1
The attached patch fixes this and allows the links to succeed; tests
still to be run.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
diff --git a/libgo/go/runtime/panic32.go b/libgo/go/runtime/panic32.go
--- a/libgo/go/runtime/panic32.go
+++ b/libgo/go/runtime/panic32.go
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
-// +build 386 amd64p32 arm mips mipsle m68k nios2 sh shbe
+// +build 386 amd64p32 arm mips mipsle m68k nios2 sh shbe sparc
package runtime
