Hello world,
attached is a patch introducing the -fallow-argument-mismatch
option, to separate this from the general kitchen sink -std=legacy.
As discussed, this can only be turned off by -w.
Regression-tested on powerpc64le-unknown-linux-gnu. Documentation
tested by "make dvi" and "make pdf".
OK for trunk?
Regads
Thomas
2019-08-25 Thomas Koenig <tkoe...@gcc.gnu.org>
PR fortran/91390
PR fortran/91473
* frontend-passes.c (gfc_check_externals): Make
gfc_errors_to_warnings conditional on -fallow-argument-mismatch.
* invoke.texi: Document -fallow-argument-mismatch.
* lang.opt: Add -fallow-argument-mismatch.
2019-08-25 Thomas Koenig <tkoe...@gcc.gnu.org>
PR fortran/91390
PR fortran/91473
* gfortran.dg/used_before_typed_4.f90: Change warning to error.
* gfortran.dg/argument_checking_20.f90: New test.
Index: gcc/fortran/frontend-passes.c
===================================================================
--- gcc/fortran/frontend-passes.c (revision 274907)
+++ gcc/fortran/frontend-passes.c (working copy)
@@ -5477,9 +5477,9 @@ gfc_check_externals (gfc_namespace *ns)
gfc_clear_error ();
- /* Turn errors into warnings if -std=legacy is given by the user. */
+ /* Turn errors into warnings if the user indicated this. */
- if (!pedantic && !(gfc_option.warn_std & GFC_STD_LEGACY))
+ if (!pedantic && flag_allow_argument_mismatch)
gfc_errors_to_warnings (true);
gfc_code_walker (&ns->code, check_externals_code, check_externals_expr, NULL);
Index: gcc/fortran/invoke.texi
===================================================================
--- gcc/fortran/invoke.texi (revision 274907)
+++ gcc/fortran/invoke.texi (working copy)
@@ -116,12 +116,12 @@ by type. Explanations are in the following sectio
@table @emph
@item Fortran Language Options
@xref{Fortran Dialect Options,,Options controlling Fortran dialect}.
-@gccoptlist{-fall-intrinsics -fallow-invalid-boz -fbackslash -fcray-pointer @gol
--fd-lines-as-code -fd-lines-as-comments -fdec -fdec-structure @gol
--fdec-intrinsic-ints -fdec-static -fdec-math -fdec-include @gol
+@gccoptlist{-fall-intrinsics -fallow-argument-mismatch -fallow-invalid-boz @gol
+-fbackslash -fcray-pointer -fd-lines-as-code -fd-lines-as-comments -fdec @gol
+-fdec-structure-fdec-intrinsic-ints -fdec-static -fdec-math -fdec-include @gol
-fdec-format-defaults -fdec-blank-format-item -fdefault-double-8 @gol
-fdefault-integer-8 -fdefault-real-8 -fdefault-real-10 -fdefault-real-16 @gol
--fdollar-ok @gol -ffixed-line-length-@var{n} -ffixed-line-length-none @gol
+-fdollar-ok -ffixed-line-length-@var{n} -ffixed-line-length-none @gol
-fpad-source -ffree-form -ffree-line-length-@var{n} -ffree-line-length-none @gol
-fimplicit-none -finteger-4-integer-8 -fmax-identifier-length @gol
-fmodule-private -ffixed-form -fno-range-check -fopenacc -fopenmp @gol
@@ -232,6 +232,14 @@ available with @command{gfortran}. As a consequen
will be ignored and no user-defined procedure with the same name as any
intrinsic will be called except when it is explicitly declared @code{EXTERNAL}.
+@item -fallow-argument-mismatch
+@opindex @code{fallow-argument-mismatch}
+Some code contains calls to external procedures whith mismatches
+between the calls and the procedure definition, or with mismatches
+between different calls. Such code is non-conforming, and will usually
+be flagged with an error. This options degrades the error to a
+warning. This option is implied by @option{-std=legacy}.
+
@item -fallow-invalid-boz
@opindex @code{allow-invalid-boz}
A BOZ literal constant can occur in a limited number of context in
Index: gcc/fortran/lang.opt
===================================================================
--- gcc/fortran/lang.opt (revision 274907)
+++ gcc/fortran/lang.opt (working copy)
@@ -365,6 +365,10 @@ d
Fortran Joined
; Documented in common.opt
+fallow-argument-mismatch
+Fortran Var(flag_allow_argument_mismatch) LangEnabledBy(Fortran,std=legacy)
+Accept argument mismatches in procedure calls.
+
faggressive-function-elimination
Fortran Var(flag_aggressive_function_elimination)
Eliminate multiple function invocations also for impure functions.
Index: gcc/testsuite/gfortran.dg/used_before_typed_4.f90
===================================================================
--- gcc/testsuite/gfortran.dg/used_before_typed_4.f90 (revision 274907)
+++ gcc/testsuite/gfortran.dg/used_before_typed_4.f90 (working copy)
@@ -22,5 +22,5 @@ END SUBROUTINE test
PROGRAM main
IMPLICIT NONE
INTEGER :: arr1(42), arr2(42)
- CALL test (3, arr1, 2, arr2) ! { dg-warning "Type mismatch in argument" }
+ CALL test (3, arr1, 2, arr2) ! { dg-error "Type mismatch in argument" }
END PROGRAM main
! { dg-do compile }
! { dg-options "-fallow-argument-mismatch" }
! PR 91390 - test the argument -fallow-argument-mismatch
! Original test case by Valera Veryazov.
program test
n=10
call s('hej')
call s('hej',n) ! { dg-warning "More actual than formal arguments" }
end program test
