Hi!
I somehow lost track of this email, sorry.
On Fri, Aug 02, 2019 at 04:59:44PM +0800, Kewen.Lin wrote:
> As to the predicate name and usage, I checked the current vector shifts,
> they don't need to check const_vector specially (like right to left
> conversion), excepting for the one "vec_shr_<mode>", but it checks for
> scalar const int.
I don't understand why we want to expand rotate-by-vector-of-immediates
if we have no insns for that? If you just use vint_operand, what happens
then?
> Btw, I've changed the
> + rtx imm_vec =
> + simplify_const_unary_operation
> back to
> + rtx imm_vec
> + = simplify_const_unary_operation
> Otherwise check_GNU_style will report "Trailing operator" error. :(
Yeah I got it the wrong way around. Either way is ugly. Oh well.
> +/* { dg-options "-O3" } */
> +/* { dg-require-effective-target powerpc_altivec_ok } */
If you use altivec_ok, you need to use -maltivec in the options, too.
This test should probably work with -O2 as well; use that, if possible.
> +/* { dg-require-effective-target powerpc_p8vector_ok } */
I don't think we need this anymore? Not sure.
Segher
