Hi Segher, on 2019/7/17 下午9:40, Segher Boessenkool wrote: > Hi Kewen, > > On Wed, Jul 17, 2019 at 04:32:15PM +0800, Kewen.Lin wrote: >> Regression testing just launched, is it OK for trunk if it's bootstrapped >> and regresstested on powerpc64le-unknown-linux-gnu? > >> +;; Expanders for rotatert to make use of vrotl >> +(define_expand "vrotr<mode>3" >> + [(set (match_operand:VEC_I 0 "vint_operand") >> + (rotatert:VEC_I (match_operand:VEC_I 1 "vint_operand") >> + (match_operand:VEC_I 2 "vint_reg_or_const_vector")))] > > Having any rotatert in a define_expand or define_insn will regress. > > So, nope, sorry. >
Thanks for clarifying! Since regression testing passed on powerpc64le,I'd like to double confirm the meaning of "regress", does it mean it's a regression from design view? Is it specific to rotatert and its related one like vrotr? If yes, it sounds we can't go with vrotr way. :( Thanks, Kewen
