On 6/10/19 12:02 PM, Matthew Beliveau wrote:
if (!uniquely_derived_from_p (basetype, t)) - warning (OPT_Wextra, "virtual base %qT inaccessible in %qT due " - "to ambiguity", basetype, t); + warning (OPT_Winaccessible_base, "virtual base %qT inaccessible in " + "%qT due to ambiguity", basetype, t);
You mentioned using -Wextra for this message, and you have a testcase for it, but here you remove the only connection between this message and -Wextra: with this patch, the virtual base warning will be enabled by default. Perhaps you want to check extra_warnings in the if condition?
Jason