On 6/6/19 2:52 PM, Jan Hubicka wrote: > Hi, > so the only point of removing this is the fact that builds would be > not reproducible with indir-call-topn-profile?
That's one reason. But the main reason is that the code is dead and not used. If you take a look at gcc/ipa-profile.c:189, the code is not supporting HIST_TYPE_INDIR_CALL_TOPN. So it's broken for few years and nobody is using that. Last reason is implementation of: __gcov_merge_icall_topn. It's over-complicated. Martin > I still kind of thing it may be useful to track multiple most common > values, so I would be in favour of keeping it just updating the documentation > of indir-call-topn-profile that it is currently incomplete and does not > lead to reproducible builds and does not handle speculation... > > Honza
