On 11/16/2011 06:53 AM, Jeff Law wrote: > I'd ask the meta question, is there a compelling reason to push this > patch into the tree now? My obvious concern is that this change > potentially effects every target and twiddles one of GCC's most > sensitive areas. Even if the patch is sound it's the kind of change > that could easily have unforeseen consequences. > > If there isn't a compelling reason, then I think it should be queued > for 4.8-stage1.
I understand your concern and the patch indeed will have an impact on the generated code of probably several back-ends. But with entering stage 3 the backend maintainers anyway are supposed to have a closer look at regressions. So I think the time to apply this is not too bad. In my opinion the patch makes reload behave more like everybody expects it to behave and at least for s390 I can say that we have several patterns which have been written with that expectation. With the patch GCC generates better code for S/390 so I would like to see this patch applied. Bye, -Andreas-
