On Tue, 14 May 2019, Richard Sandiford wrote: > Several SVE patterns need define_insn_and_splits that generate the > same insn_code, but with different operands. That's probably a > niche requirement, but it's cropping up often enough on the ACLE > branch that I think it would be good to have a syntactic sugar for it. > > This patch therefore adds a new construct called define_insn_and_rewrite.
> It's basically a define_insn_and_split with an implicit split pattern, > obtained by copying the insn pattern and replacing match_operands with > match_dups and match_operators with match_op_dups. I think that sentence should be in the documentation, in one of the introductory sentences. > Any comments? > Suggestions for better names? I'll pass on this, for now. ;-) But, IMHO it lacks an allusion to define_insn_and_split. > Index: gcc/doc/md.texi > +@end smallexample Can you please add the equivalent define_insn_and_split "expansion" to the example? It'd help understanding the concept graphically at a glance. brgds, H-P
