Eric Botcazou <ebotca...@adacore.com> writes:
>> This patch therefore adds a new construct called define_insn_and_rewrite.
>> It's basically a define_insn_and_split with an implicit split pattern,
>> obtained by copying the insn pattern and replacing match_operands with
>> match_dups and match_operators with match_op_dups.
>
> Isn't that what define_subst does in a different context?
>
>> Any comments?  Suggestions for better names?
>
> define_insn_and_subst?

define_subst is a static substitution though, creating multiple insn codes,
whereas the substitution here is dynamic and can be controlled by C++ code.
It might be confusing to link the two.

Thanks,
Richard

Reply via email to