On Sun, May 12, 2019 at 11:06 AM Thomas Koenig <tkoe...@netcologne.de> wrote: > > Am 12.05.19 um 00:02 schrieb Jakub Jelinek: > > Is it correct to use macros in user namespace? Shouldn't they be say __ > > prefixed, or even have __GFC_ or __GFORTRAN_ in them? > > I think Jakub has a point there -- something like __GFC_DOUBLE_COMPLEX > would probably be better. > > So, OK with that change.
Thanks, committed as r271106. I prefixed the macros with __GFORTRAN_, as that seems clearer to users where those come from as gfc seems used mostly in the compiler internals. Any opinions whether it should be committed to 9 as well? > (I thought for a second about guarding about double inclusion, but > including prototypes twice is harmless, and this should be the > user's responsibility). I thought about adding include guards as well, but the problem is that we don't know which name the end user wants to save the output as. -- Janne Blomqvist
