On Thu, Apr 11, 2019 at 12:47 PM Jakub Jelinek <ja...@redhat.com> wrote: > > On Thu, Apr 11, 2019 at 12:44:40PM +0200, Martin Liška wrote: > > On 4/11/19 11:57 AM, Richard Biener wrote: > > > On Thu, Apr 11, 2019 at 10:37 AM Martin Liška <mli...@suse.cz> wrote: > > >> > > >> Hi. > > >> > > >> The patch is catching duplicate 'default' values in target attribute. > > >> > > >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > >> > > >> Ready to be installed? > > > > > > I wonder if it isn't better to ignore duplicate "default"s (given you > > > needed to > > > adjust a testcase even)? > > > > Well, possibly yes. But I would prefer to have a more strict checking. > > I agree, default, default is not really useful and rejecting it is fine. > Having a testcase covering that is of course desirable.
There is one in the patch. That said, I was worried to go down the same route as that volatile asm thing and the patch needs to be on branches as well? Anyhow, patch is OK for trunk. Richard. > Jakub
