On Thu, Apr 11, 2019 at 10:37 AM Martin Liška <mli...@suse.cz> wrote: > > Hi. > > The patch is catching duplicate 'default' values in target attribute. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed?
I wonder if it isn't better to ignore duplicate "default"s (given you needed to adjust a testcase even)? Richard. > Thanks, > Martin > > gcc/ChangeLog: > > 2019-04-10 Martin Liska <mli...@suse.cz> > > PR middle-end/89970 > * multiple_target.c (create_dispatcher_calls): Wrap ifunc > in error message. > (separate_attrs): Handle multiple 'default's. > (expand_target_clones): Rework error handling code. > > gcc/testsuite/ChangeLog: > > 2019-04-10 Martin Liska <mli...@suse.cz> > > PR middle-end/89970 > * gcc.target/i386/mvc15.c: New test. > * gcc.target/i386/mvc3.c: Quote target in error pattern. > * gcc.target/i386/mvc4.c: Remove duplicit 'default'. > --- > gcc/multiple_target.c | 38 ++++++++++++++++++--------- > gcc/testsuite/gcc.target/i386/mvc15.c | 11 ++++++++ > gcc/testsuite/gcc.target/i386/mvc3.c | 2 +- > gcc/testsuite/gcc.target/i386/mvc4.c | 2 +- > 4 files changed, 38 insertions(+), 15 deletions(-) > create mode 100644 gcc/testsuite/gcc.target/i386/mvc15.c > >
