On Mon, 28 Jan 2019, Richard Biener wrote: > On Mon, Jan 21, 2019 at 7:35 PM Iain Buclaw <ibuc...@gdcproject.org> wrote: > > > > Hi, > > > > Following on from the last, this adds target-zlib to target_libraries > > and updates libphobos build scripts to link to libz_convenience.a. > > The D front-end already has target-zlib in d/config-lang.in. > > > > Is the top-level part OK? I considered disabling target-zlib if > > libphobos is not being built, but decided against unless it's > > requested. > > Hmm, you overload --with-system-zlib to apply to both host and target > (I guess it already applied to build), not sure if that's really desired?
I think it's best to keep this sort of option separate for host and target. > You are also falling back to in-tree zlib if --with-system-zlib was > specified but no zlib was found - I guess for cross builds that > will easily get not noticed... The toplevel --with-system-zlib makes > it much harder and simply fails. And I think failing is better if such an option is specified but zlib is not found. -- Joseph S. Myers jos...@codesourcery.com
