On Mon, Jan 21, 2019 at 7:35 PM Iain Buclaw <ibuc...@gdcproject.org> wrote: > > Hi, > > Following on from the last, this adds target-zlib to target_libraries > and updates libphobos build scripts to link to libz_convenience.a. > The D front-end already has target-zlib in d/config-lang.in. > > Is the top-level part OK? I considered disabling target-zlib if > libphobos is not being built, but decided against unless it's > requested.
Hmm, you overload --with-system-zlib to apply to both host and target (I guess it already applied to build), not sure if that's really desired? I suppose libphobos is the first target library linking against zlib? You are also falling back to in-tree zlib if --with-system-zlib was specified but no zlib was found - I guess for cross builds that will easily get not noticed... The toplevel --with-system-zlib makes it much harder and simply fails. Joseph, does it make sense to do this? Richard. > -- > Iain > --- > ChangeLog: > > 2019-01-21 Iain Buclaw <ibuc...@gdcproject.org> > > * configure.ac: configure.ac: Add target-zlib to target_libraries. > * configure: Regenerate. > > libphobos/ChangeLog: > > 2019-01-21 Iain Buclaw <ibuc...@gdcproject.org> > > * m4/druntime/libraries.m4 (DRUNTIME_LIBRARIES_ZLIB): Use > libz_convenience.a if not using system zlib. > * Makefile.in: Regenerate. > * configure: Regenerate. > * libdruntime/Makefile.in: Regenerate. > * src/Makefile.am: Remove ZLIB_CSOURCES and AM_CFLAGS. > * src/Makefile.in: Regenerate. > * testsuite/Makefile.in: Regenerate. > > ---
