Hi Chung-Lin! On Tue, 25 Sep 2018 21:11:42 +0800, Chung-Lin Tang <chunglin_t...@mentor.com> wrote: > These are the testsuite/libgomp.oacc-c-c++-common/* changes.
Please commit the following three hunks to trunk: the code as present doesn't declare its async/wait dependencies correctly. To record the review effort, please include "Reviewed-by: Thomas Schwinge <tho...@codesourcery.com>" in the commit log, see <https://gcc.gnu.org/wiki/Reviewed-by>. > diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/data-2-lib.c > b/libgomp/testsuite/libgomp.oacc-c-c++-common/data-2-lib.c > index 2ddfa7d..f553d3d 100644 > --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/data-2-lib.c > +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/data-2-lib.c > @@ -153,7 +153,7 @@ main (int argc, char **argv) > d[ii] = ((a[ii] * a[ii] + a[ii]) / a[ii]) - a[ii]; > > #pragma acc parallel present (a[0:N], b[0:N], c[0:N], d[0:N], e[0:N], N) \ > - async (4) > + wait (1, 2, 3) async (4) > for (int ii = 0; ii < N; ii++) > e[ii] = a[ii] + b[ii] + c[ii] + d[ii]; > > diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/data-2.c > b/libgomp/testsuite/libgomp.oacc-c-c++-common/data-2.c > index 0c6abe6..81d623a 100644 > --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/data-2.c > +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/data-2.c > @@ -162,7 +162,7 @@ main (int argc, char **argv) > d[ii] = ((a[ii] * a[ii] + a[ii]) / a[ii]) - a[ii]; > > #pragma acc parallel present (a[0:N], b[0:N], c[0:N], d[0:N], e[0:N]) \ > - wait (1) async (4) > + wait (1, 2, 3) async (4) > for (int ii = 0; ii < N; ii++) > e[ii] = a[ii] + b[ii] + c[ii] + d[ii]; > > diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/data-3.c > b/libgomp/testsuite/libgomp.oacc-c-c++-common/data-3.c > index 0bf706a..5ec50b8 100644 > --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/data-3.c > +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/data-3.c > @@ -138,7 +138,7 @@ main (int argc, char **argv) > d[ii] = ((a[ii] * a[ii] + a[ii]) / a[ii]) - a[ii]; > > #pragma acc parallel present (a[0:N], b[0:N], c[0:N], d[0:N], e[0:N]) \ > - wait (1,5) async (4) > + wait (1, 2, 3, 5) async (4) > for (int ii = 0; ii < N; ii++) > e[ii] = a[ii] + b[ii] + c[ii] + d[ii]; > Grüße Thomas
