On 11/6/18 9:37 AM, Hafiz Abid Qadeer wrote: > Hi All, > I was investigating a character set related problem with windows hosted > GDB and I tracked it down to a typo in iconv.m4. This typo caused > libiconv detection to fail and related support was not built into gdb. > > The problem is with the following line. > CPPFLAGS="$LIBS $INCICONV" > which should have been > CPPFLAGS="$CPPFLAGS $INCICONV" > > OK to commit the attached patch? > > 2018-11-06 Hafiz Abid Qadeer <ab...@codesourcery.com> > > * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS. > Append $INCICONV to it. > * gcc/configure: Regenerate. > * libcpp/configure: Likewise. > * libstdc++-v3/configure: Likewise. > * intl/configure: Likewise. > > Thanks, > THanks. I wasn't sure if you had commit privs, so I went ahead and installed the patch.
Jeff