> Yes, the changelog is wrong indeed. Registers in a SET_DEST memory are > uses, so they are like SET_SRC in this context which is why I think the > patch does belong in try_replace_reg. Georg, what do you think of a > changelog like this: > > Also try to replace uses of FROM that appear in SET_DEST.
OK, this makes sense. validate_replace_src_group actually does this too. > I agree; like above, the patch should also change the head comment like > this: > > /* Try to replace all uses of FROM in INSN with TO. Returns > nonzero is successful. */ No 's' in "Returns". Note that the comment is also off: + /* If above failed and this is a single set, try to simplify the source of + the set given our substitution. We could perhaps try this for multiple + SETs, but it probably won't buy us anything. */ + rtx addr = simplify_replace_rtx (SET_DEST (set), from, to); What does "If above failed" refer to? Again "source" instead of "destination". -- Eric Botcazou
