Hi Than,
> OK, thanks again. Another fix sent:
>
> https://go-review.googlesource.com/c/gofrontend/+/145021
great, thanks again. While the two previous patches were enough to get
decent Solaris 11 results, on Solaris 10 all libgo tests still FAIL like
this:
_testmain.go:9:25: error: reference to undefined identifier 'tar.TestReaderntar'
9 | {"TestFileWriter",
tar.TestReaderntar.TestPartialReadntar.TestUninitializedReadntar.TestReadTruncationntar.TestReadHeaderOnlyntar.TestMergePAXntar.TestParsePAXntar.TestReadOldGNUSparseMapntar.TestReadGNUSparsePAXHeadersntar.TestFileReaderntar.TestFitsInBase256ntar.TestParseNumericntar.TestFormatNumericntar.TestFitsInOctalntar.TestParsePAXTimentar.TestFormatPAXTimentar.TestParsePAXRecordntar.TestFormatPAXRecordntar.TestSparseEntriesntar.TestFileInfoHeaderntar.TestFileInfoHeaderDirntar.TestFileInfoHeaderSymlinkntar.TestRoundTripntar.TestHeaderRoundTripntar.TestHeaderAllowedFormatsntar.TestWriterntar.TestPaxntar.TestPaxSymlinkntar.TestPaxNonAsciintar.TestPaxXattrsntar.TestPaxHeadersSortedntar.TestUSTARLongNamentar.TestValidTypeflagWithPAXHeaderntar.TestWriterErrorsntar.TestSplitUSTARPathntar.TestIssue12594ntar.TestFileWriter},
| ^
FAIL: archive/tar
This is due to gotest (symtogo):
echo "$result" | sed -e 's/ /\n/g'
which even Solaris 11.5 Beta /bin/sed treats like this:
$ echo 'a b' | /bin/sed -e 's/ /\n/g'
anb
I still got decent results because GNU sed is earlier in my PATH on
Solaris 11, but Solaris 10 lacks it. However, this seems to work (both
with Solaris sed and GNU sed):
echo "$result" | /bin/sed -e 's/ /\
/g'
It allows the Solaris 10 libgo testing to work, but can't tell if that's
the most portable way to do this.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
diff --git a/libgo/testsuite/gotest b/libgo/testsuite/gotest
--- a/libgo/testsuite/gotest
+++ b/libgo/testsuite/gotest
@@ -529,7 +529,8 @@ symtogo() {
result="${result} ${s}"
fi
done
- echo "$result" | sed -e 's/ /\n/g'
+ echo "$result" | sed -e 's/ /\
+/g'
}
{
