Hi Than,

> Thanks for reporting this.
>
> Sent https://go-review.googlesource.com/c/gofrontend/+/145017 with a
> tentative fix.

fine, thanks.

While actually running the libgo testsuite, another issue came up: all
tests FAIL like this:

/vol/gcc/src/hg/trunk/local/libgo/testsuite/gotest[516]: local: not found [No 
such file or directory]
FAIL: crypto/sha512

The Solaris 11 /bin/sh is ksh93, and Solaris 10 even comes with the
original Bourne shell, neither of which support the unportable local
command.  AFAICS, there's no need at all to use it, and indeed with the
following patch libgo testsuite results are as before the patch.

        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


diff --git a/libgo/testsuite/gotest b/libgo/testsuite/gotest
--- a/libgo/testsuite/gotest
+++ b/libgo/testsuite/gotest
@@ -513,9 +513,9 @@ localname() {
 #    Returned:          leaf.Mumble
 #
 symtogo() {
-  local s=""
-  local result=""
-  local ndots=""
+  s=""
+  result=""
+  ndots=""
   for tp in $*
   do
     s=$(echo "$tp" | sed -e 's/\.\.z2f/%/g' | sed -e 's/.*%//')

Reply via email to