On Fri, Jul 6, 2018 at 1:04 PM, Christophe Lyon <christophe.l...@linaro.org> wrote: > On Fri, 6 Jul 2018 at 13:56, Ramana Radhakrishnan > <ramana....@googlemail.com> wrote: >> >> On Fri, Jul 6, 2018 at 10:16 AM, Tamar Christina >> <tamar.christ...@arm.com> wrote: >> > Hi All, >> > >> > This fixes a -Wpedantic error with the testcase because of extra ; left >> > after the >> > functions. >> > >> > Regtested single test on aarch64-none-elf and no issues. >> > >> > Committed under the GCC obvious rule. >> >> >> So I am curious as to why this shows up in Christophe's test but not >> in any of your test runs or indeed the testruns with our scripts. >> >> Ideally this should have been caught by the testing you do , just >> curious as to why -Wpedantic is getting caught in Christophe's bot but >> not our bot. Searching through gcc.target/aarch64 I see no use of >> -Wpedantic in any of the exp files. So is this coming from the top >> level in your testing Christophe ? >> > > In my gcc.log, the compilation line is: > /xgcc -B//gcc/ /gcc/testsuite/gcc.target/aarch64/struct_cpy.c > -fno-diagnostics-show-caret -fdiagnostics-color=never -ansi > -pedantic-errors -ffat-lto-objects -S -o struct_cpy.s > > I do not override it at the top level.
I now see aarch64.exp: set DEFAULT_CFLAGS " -ansi -pedantic-errors" So looks like a botched test run then. My bad.. Ramana > >> Ramana >> > >> > Thanks, >> > Tamar >> > >> > gcc/testsuite/ >> > 2018-07-06 Tamar Christina <tamar.christ...@arm.com> >> > >> > * gcc.target/aarch64/struct_cpy.c: Remove ;. >> > >> > --
