On 06/22/2018 05:06 AM, Martin Liška wrote:
> On 06/20/2018 04:41 PM, David Malcolm wrote:
>> On Mon, 2018-05-14 at 14:50 +0200, Martin Liška wrote:
>>> First part with introduction of auto_string_vec class.
>>>
>> FWIW, I'm fine with the changes to the jit subdir, but I don't think I
>> have approval rights on the vec.h changes.
> Hi.
>
> Good, I'll wait a review from a global reviewer.
>
>> BTW, was the move of vec_alloc in vec.h intentional? (I take it that
>> it's the same before/after, but it seems to have added some churn to
>> the vec.h part of the patch).
> It's not intentional, fixed in attached patch.
>
> Martin
>
>> Dave
>>
>
> 0001-Introduce-auto_string_vec-class.patch
>
>
> From abd1b31ec6807d101bbf868acfbdf3bd02319463 Mon Sep 17 00:00:00 2001
> From: marxin <mli...@suse.cz>
> Date: Mon, 14 May 2018 14:00:07 +0200
> Subject: [PATCH] Introduce auto_string_vec class.
>
> gcc/ChangeLog:
>
> 2018-05-14 Martin Liska <mli...@suse.cz>
>
> * vec.h (class auto_string_vec): New (moved from auto_argvec).
> (auto_string_vec::~auto_string_vec): Likewise.
>
> gcc/jit/ChangeLog:
>
> 2018-05-14 Martin Liska <mli...@suse.cz>
>
> * jit-playback.c (class auto_argvec): Moved to vec.h.
> (auto_argvec::~auto_argvec): Likewise.
> (compile): Use the renamed name.
> (invoke_driver): Likewise.
OK
jeff
