On Fri, 2018-06-22 at 13:25 +0200, Martin Liška wrote:
> On 06/20/2018 05:27 PM, David Malcolm wrote:
> > On Mon, 2018-05-14 at 14:51 +0200, Martin Liška wrote:
[...snip...]
> > Thanks for working on this; the rest looks good to me (though as I
> > said, I'm not officially a reviewer for this).
FWIW I noticed a few other minor nits in the revised version of the
patch, all just in comments:
> diff --git a/gcc/gcc.c b/gcc/gcc.c
> index dda1fd35398..9e5b153bc53 100644
> --- a/gcc/gcc.c
> +++ b/gcc/gcc.c
> @@ -221,6 +221,10 @@ static int print_help_list;
>
> static int print_version;
>
> +/* Flag that stores string value for which we provide bash completion. */
> +
> +static const char *completion = NULL;
> +
Maybe reword "value" to "prefix" in the above?
[...snip...]
> diff --git a/gcc/selftest.c b/gcc/selftest.c
> index 74adc63e65c..78ae778ca14 100644
> --- a/gcc/selftest.c
> +++ b/gcc/selftest.c
> @@ -125,6 +125,39 @@ assert_str_contains (const location &loc,
> desc_haystack, desc_needle, val_haystack, val_needle);
> }
>
> +/* Implementation detail of ASSERT_STR_STARTSWITH.
> + Use strstr to determine if val_haystack starts with val_needle.
> + ::selftest::pass if it starts.
> + ::selftest::fail if it does not start. */
> +
> +void
> +assert_str_startswith (const location &loc,
> + const char *desc_str,
> + const char *desc_prefix,
> + const char *val_str,
> + const char *val_prefix)
> +{
The above leading comment is out of date, maybe change it to:
/* Implementation detail of ASSERT_STR_STARTSWITH.
Determine if VAL_STR starts with VAL_PREFIX.
::selftest::pass if VAL_STR does start with VAL_PREFIX.
::selftest::fail if it does not, or either is NULL (using
DESC_STR and DESC_PREFIX in the error message). */
> +/* Evaluate STRING and PREFIX and determine if STRING starts with PREFIX.
> + ::selftest::pass if STRING does start with PREFIX.
> + ::selftest::fail if does not, or either is NULL. */
> +
> +#define ASSERT_STR_STARTSWITH(STR, PREFIX) \
> + SELFTEST_BEGIN_STMT
> \
> + ::selftest::assert_str_startswith (SELFTEST_LOCATION, #STR, #PREFIX,
> \
> + (STR), (PREFIX)); \
> + SELFTEST_END_STMT
> +
The argnames in the leading comment don't match those in the macro
itself; change the usages of STRING in the leading comment to STR.
Dave
